Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user interaction tracking not working for Jetpack Compose 1.5+ #3010

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

markushi
Copy link
Member

📜 Description

Extends the behaviour for determining if a LayoutNode is clickable/scrollable. This change should be backwards compatible as the old logic still stays intact for older versions of Jetpack Compose.

💡 Motivation and Context

Fixes #2978

💚 How did you test it?

Manual tests, we definitely should setup a test matrix for different Jetpack Compose versions.

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.14 ms 468.64 ms 77.50 ms
Size 1.72 MiB 2.29 MiB 576.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
bc4be3b 360.40 ms 435.04 ms 74.64 ms
0bf143e 368.35 ms 437.47 ms 69.12 ms
86f0096 368.63 ms 446.92 ms 78.29 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms
c7e2fbc 393.98 ms 478.24 ms 84.27 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
4bf95dd 345.96 ms 414.24 ms 68.28 ms

App size

Revision Plain With Sentry Diff
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
bc4be3b 1.72 MiB 2.29 MiB 576.53 KiB
0bf143e 1.72 MiB 2.29 MiB 576.50 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB

Previous results on branch: fix/jetpack-compose-gesture-target

Startup times

Revision Plain With Sentry Diff
a60d1a1 382.54 ms 479.84 ms 97.30 ms

App size

Revision Plain With Sentry Diff
a60d1a1 1.72 MiB 2.29 MiB 576.56 KiB

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual tests, we definitely should setup a test matrix for different Jetpack Compose versions.

💯 I think our agp-matrix workflow already runs compose instrumentation tests, so we should just add another dimension there. Will be hard to keep it in sync though

@markushi markushi merged commit 1ab82a3 into main Oct 24, 2023
21 checks passed
@markushi markushi deleted the fix/jetpack-compose-gesture-target branch October 24, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Compose user interaction integration is broken
2 participants