Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DSN uses http/https protocol #3044

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Conversation

markushi
Copy link
Member

@markushi markushi commented Nov 9, 2023

馃摐 Description

Fixes #3025
Inspired by https://github.com/getsentry/sentry-python/blob/36c2650ccc6edcd300e2d207d7123b12c8b77b27/sentry_sdk/utils.py#L237-L238

馃挕 Motivation and Context

Ensure we crash early on when an invalid dsn is provided.

馃挌 How did you test it?

Added unit tests

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against 3394789

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 431.47 ms 515.04 ms 83.58 ms
Size 1.72 MiB 2.29 MiB 577.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2fad834 390.07 ms 470.80 ms 80.73 ms
283d83e 416.81 ms 497.22 ms 80.41 ms
c7e2fbc 398.35 ms 468.52 ms 70.17 ms
86f0096 381.33 ms 476.58 ms 95.25 ms
c3f503e 360.41 ms 434.67 ms 74.27 ms
3d8bd2b 379.45 ms 450.36 ms 70.90 ms
3d8bd2b 375.34 ms 446.32 ms 70.98 ms
93a76ca 397.30 ms 455.16 ms 57.87 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms

App size

Revision Plain With Sentry Diff
2fad834 1.72 MiB 2.29 MiB 577.53 KiB
283d83e 1.72 MiB 2.29 MiB 577.69 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
c3f503e 1.72 MiB 2.29 MiB 577.04 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB

Previous results on branch: feat/validate-dsn-protocol

Startup times

Revision Plain With Sentry Diff
8ec675e 353.58 ms 461.50 ms 107.92 ms

App size

Revision Plain With Sentry Diff
8ec675e 1.72 MiB 2.29 MiB 577.76 KiB

markushi and others added 2 commits November 9, 2023 14:34
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@markushi markushi merged commit a73f0be into main Nov 10, 2023
20 checks passed
@markushi markushi deleted the feat/validate-dsn-protocol branch November 10, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate into NoClassDefFoundError
3 participants