Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp CI setup #3074

Merged
merged 34 commits into from
Jan 10, 2024
Merged

Revamp CI setup #3074

merged 34 commits into from
Jan 10, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 1, 2023

#skip-changelog

  • Speed up some tests depending on timeouts
  • Use gradle-build-action for most of the jobs
  • Split up PR and release workflows, for releases we only build distribution artifacts now, and for PRs we only run tests and lint
  • Enable gradle caching to benefit form gradle-build-action
  • Only run tasks that we actually need for workflows
  • Parallelize tests
  • Remove unnecessary tests (e.g. SdkBenchmark init test, already done as part of the app-metrics job)
  • Potentially fix an issue when we didn't set the release and other fields correctly for ANRv2

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 375.40 ms 454.00 ms 78.60 ms
Size 1.72 MiB 2.27 MiB 558.30 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4e29063 364.08 ms 445.51 ms 81.43 ms
93a76ca 381.08 ms 459.22 ms 78.14 ms
4e260b3 388.40 ms 468.98 ms 80.58 ms
937879e 417.64 ms 550.45 ms 132.81 ms
93a76ca 377.96 ms 447.52 ms 69.56 ms
d6d2b2e 463.14 ms 545.56 ms 82.42 ms
86f0096 371.86 ms 439.78 ms 67.92 ms
3d8bd2b 364.76 ms 469.98 ms 105.22 ms
8fd337b 349.16 ms 459.22 ms 110.06 ms
b172d4e 413.47 ms 479.02 ms 65.55 ms

App size

Revision Plain With Sentry Diff
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
86f0096 1.72 MiB 2.29 MiB 576.50 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
8fd337b 1.72 MiB 2.27 MiB 555.00 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB

Previous results on branch: rz/chore/agp-matrix-updates

Startup times

Revision Plain With Sentry Diff
e5af401 385.81 ms 467.36 ms 81.55 ms
6806d9f 395.67 ms 463.74 ms 68.07 ms
3cd802a 398.12 ms 477.78 ms 79.66 ms
286023f 385.79 ms 410.02 ms 24.23 ms
f1b54ea 391.90 ms 478.12 ms 86.22 ms
a50dca0 387.17 ms 447.06 ms 59.89 ms
db712c6 607.33 ms 737.18 ms 129.85 ms
69a3bb5 359.50 ms 473.12 ms 113.62 ms
eac065a 369.04 ms 459.48 ms 90.44 ms
3238623 386.66 ms 456.06 ms 69.40 ms

App size

Revision Plain With Sentry Diff
e5af401 1.72 MiB 2.27 MiB 558.42 KiB
6806d9f 1.72 MiB 2.27 MiB 558.42 KiB
3cd802a 1.72 MiB 2.27 MiB 558.42 KiB
286023f 1.72 MiB 2.27 MiB 558.30 KiB
f1b54ea 1.72 MiB 2.27 MiB 558.42 KiB
a50dca0 1.72 MiB 2.27 MiB 558.30 KiB
db712c6 1.72 MiB 2.27 MiB 558.52 KiB
69a3bb5 1.72 MiB 2.27 MiB 558.42 KiB
eac065a 1.72 MiB 2.27 MiB 558.30 KiB
3238623 1.72 MiB 2.27 MiB 558.42 KiB

@romtsn romtsn marked this pull request as ready for review January 8, 2024 09:28
@romtsn romtsn changed the title Bump AGP versions and try to make it green Revamp CI setup Jan 8, 2024
@@ -174,6 +177,12 @@ class EnvelopeTests : BaseUiTest() {

@Test
fun checkTimedOutProfile() {
Assume.assumeFalse(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try with the latest changes from master, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean your fixes for the envelopes with 0-byte bodies? yeah I tried that, still happening

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn merged commit 2fe9631 into main Jan 10, 2024
21 checks passed
@romtsn romtsn deleted the rz/chore/agp-matrix-updates branch January 10, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants