Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR] Allow RRWeb breadcrumb customization from hybrid SDKs #3448

Merged
merged 5 commits into from
Jun 18, 2024
Merged

[SR] Allow RRWeb breadcrumb customization from hybrid SDKs #3448

merged 5 commits into from
Jun 18, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 30, 2024 •
edited
Loading

#skip-changelog

📜 Description

  • Extract breadcrumb conversion to a separate class, so the hybrid SDKs can override the logic
  • Also make the default converter public and open, so others can delegate to it to do the conversion for some categories

@romtsn romtsn requested a review from vaind May 30, 2024 12:39
@romtsn romtsn changed the title [SR} Allow RRWeb breadcrumb customization from hybrid SDKs [SR] Allow RRWeb breadcrumb customization from hybrid SDKs May 30, 2024
vaind
vaind approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for RN

@romtsn romtsn marked this pull request as ready for review June 3, 2024 15:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 382.49 ms 450.28 ms 67.79 ms
Size 1.70 MiB 2.33 MiB 639.84 KiB

Previous results on branch: rz/feat/session-replay-breadcrumbs-customizer

Startup times

Revision Plain With Sentry Diff
7ecacab 383.94 ms 456.96 ms 73.02 ms

App size

Revision Plain With Sentry Diff
7ecacab 1.70 MiB 2.33 MiB 639.84 KiB

@vaind vaind mentioned this pull request Jun 3, 2024
Merged
4 tasks
@vaind
Copy link
Collaborator

vaind commented Jun 11, 2024

@romtsn anything blocking this?

@romtsn
Copy link
Member Author

romtsn commented Jun 18, 2024

@romtsn anything blocking this?

another reviewer approval and my vacation 😄

markushi
markushi approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean!

...ry-android-replay/src/main/java/io/sentry/android/replay/DefaultReplayBreadcrumbConverter.kt Outdated Show resolved Hide resolved
@romtsn romtsn merged commit 11437d4 into rz/feat/session-replay Jun 18, 2024
20 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-breadcrumbs-customizer branch June 18, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@vaind vaind vaind approved these changes

@adinauer adinauer Awaiting requested review from adinauer

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romtsn @vaind @markushi