Skip to content

Commit 993c23b

Browse files
committed
fix browser utils unit tests
1 parent 4ebf1f7 commit 993c23b

File tree

2 files changed

+161
-135
lines changed

2 files changed

+161
-135
lines changed

packages/browser-utils/test/browser/browserMetrics.test.ts

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,19 @@ describe('_addResourceSpans', () => {
294294
['url.same_origin']: true,
295295
['network.protocol.name']: 'http',
296296
['network.protocol.version']: '1.1',
297+
'http.request.connect_start': expect.any(Number),
298+
'http.request.connection_end': expect.any(Number),
299+
'http.request.domain_lookup_end': expect.any(Number),
300+
'http.request.domain_lookup_start': expect.any(Number),
301+
'http.request.fetch_start': expect.any(Number),
302+
'http.request.redirect_end': expect.any(Number),
303+
'http.request.redirect_start': expect.any(Number),
304+
'http.request.request_start': expect.any(Number),
305+
'http.request.response_end': expect.any(Number),
306+
'http.request.response_start': expect.any(Number),
307+
'http.request.secure_connection_start': expect.any(Number),
308+
'http.request.time_to_first_byte': 0,
309+
'http.request.worker_start': expect.any(Number),
297310
},
298311
}),
299312
);
@@ -409,7 +422,7 @@ describe('_addResourceSpans', () => {
409422
expect(spans).toHaveLength(1);
410423
expect(spanToJSON(spans[0]!)).toEqual(
411424
expect.objectContaining({
412-
data: {
425+
data: expect.objectContaining({
413426
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.css',
414427
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
415428
['http.decoded_response_content_length']: entry.decodedBodySize,
@@ -421,7 +434,7 @@ describe('_addResourceSpans', () => {
421434
['url.same_origin']: true,
422435
['network.protocol.name']: 'http',
423436
['network.protocol.version']: '2',
424-
},
437+
}),
425438
}),
426439
);
427440
});
@@ -446,15 +459,15 @@ describe('_addResourceSpans', () => {
446459
expect(spans).toHaveLength(1);
447460
expect(spanToJSON(spans[0]!)).toEqual(
448461
expect.objectContaining({
449-
data: {
462+
data: expect.objectContaining({
450463
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'resource.css',
451464
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
452465
'server.address': 'example.com',
453466
'url.same_origin': true,
454467
'url.scheme': 'https',
455468
['network.protocol.name']: 'http',
456469
['network.protocol.version']: '3',
457-
},
470+
}),
458471
description: '/assets/to/css',
459472
timestamp: 468,
460473
op: 'resource.css',
@@ -494,6 +507,19 @@ describe('_addResourceSpans', () => {
494507
'url.scheme': 'https',
495508
['network.protocol.name']: 'http',
496509
['network.protocol.version']: '3',
510+
'http.request.connect_start': expect.any(Number),
511+
'http.request.connection_end': expect.any(Number),
512+
'http.request.domain_lookup_end': expect.any(Number),
513+
'http.request.domain_lookup_start': expect.any(Number),
514+
'http.request.fetch_start': expect.any(Number),
515+
'http.request.redirect_end': expect.any(Number),
516+
'http.request.redirect_start': expect.any(Number),
517+
'http.request.request_start': expect.any(Number),
518+
'http.request.response_end': expect.any(Number),
519+
'http.request.response_start': expect.any(Number),
520+
'http.request.secure_connection_start': expect.any(Number),
521+
'http.request.time_to_first_byte': 0,
522+
'http.request.worker_start': expect.any(Number),
497523
},
498524
description: '/assets/to/css',
499525
timestamp: 468,

0 commit comments

Comments
 (0)