Skip to content

Commit a6dc41f

Browse files
committed
tests: avoid importing semantic attrs exported by indirect dep
1 parent cf16bb1 commit a6dc41f

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

dev-packages/e2e-tests/test-applications/nuxt-3/tests/storage-aliases.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
3-
import { SEMANTIC_ATTRIBUTE_CACHE_HIT, SEMANTIC_ATTRIBUTE_CACHE_KEY } from '@sentry/core';
43
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/nuxt';
54

65
test.describe('Storage Instrumentation - Aliases', () => {
76
const prefixKey = (key: string) => `test-storage:${key}`;
7+
const SEMANTIC_ATTRIBUTE_CACHE_KEY = 'cache.key';
8+
const SEMANTIC_ATTRIBUTE_CACHE_HIT = 'cache.hit';
89

910
test('instruments storage alias methods (get, set, has, del, remove) and creates spans', async ({ request }) => {
1011
const transactionPromise = waitForTransaction('nuxt-3', transactionEvent => {

dev-packages/e2e-tests/test-applications/nuxt-3/tests/storage.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
3-
import { SEMANTIC_ATTRIBUTE_CACHE_HIT, SEMANTIC_ATTRIBUTE_CACHE_KEY } from '@sentry/core';
43
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/nuxt';
54

65
test.describe('Storage Instrumentation', () => {
76
const prefixKey = (key: string) => `test-storage:${key}`;
7+
const SEMANTIC_ATTRIBUTE_CACHE_KEY = 'cache.key';
8+
const SEMANTIC_ATTRIBUTE_CACHE_HIT = 'cache.hit';
89

910
test('instruments all storage operations and creates spans with correct attributes', async ({ request }) => {
1011
const transactionPromise = waitForTransaction('nuxt-3', transactionEvent => {

dev-packages/e2e-tests/test-applications/nuxt-4/tests/storage-aliases.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
3-
import { SEMANTIC_ATTRIBUTE_CACHE_HIT, SEMANTIC_ATTRIBUTE_CACHE_KEY } from '@sentry/core';
43
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/nuxt';
54

65
test.describe('Storage Instrumentation - Aliases', () => {
76
const prefixKey = (key: string) => `test-storage:${key}`;
7+
const SEMANTIC_ATTRIBUTE_CACHE_KEY = 'cache.key';
8+
const SEMANTIC_ATTRIBUTE_CACHE_HIT = 'cache.hit';
89

910
test('instruments storage alias methods (get, set, has, del, remove) and creates spans', async ({ request }) => {
1011
const transactionPromise = waitForTransaction('nuxt-4', transactionEvent => {

dev-packages/e2e-tests/test-applications/nuxt-4/tests/storage.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
3-
import { SEMANTIC_ATTRIBUTE_CACHE_HIT, SEMANTIC_ATTRIBUTE_CACHE_KEY } from '@sentry/core';
43
import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/nuxt';
54

65
test.describe('Storage Instrumentation', () => {
76
const prefixKey = (key: string) => `test-storage:${key}`;
7+
const SEMANTIC_ATTRIBUTE_CACHE_KEY = 'cache.key';
8+
const SEMANTIC_ATTRIBUTE_CACHE_HIT = 'cache.hit';
89

910
test('instruments all storage operations and creates spans with correct attributes', async ({ request }) => {
1011
const transactionPromise = waitForTransaction('nuxt-4', transactionEvent => {

0 commit comments

Comments
 (0)