Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub): Don't set lastEventID for transactions #3966

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

AbhiPrasad
Copy link
Member

As lastEventID is often just used for UserFeedback, let's not set it when we capture transactions. This is technically a breaking change in terms of behaviour, but we elect to not put this in a major as the previous behaviour was incorrect.

Validated with unit tests.

packages/hub/src/hub.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.66 KB (+0.04% 🔺)
@sentry/browser - Webpack 22.67 KB (+0.05% 🔺)
@sentry/react - Webpack 22.71 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.09 KB (+0.03% 🔺)

@AbhiPrasad AbhiPrasad merged commit 99f9b55 into master Sep 9, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-lasteventid-transaction branch September 9, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants