Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): fix path separator substitution to replace all \\ #6932

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Jan 25, 2023

Fixes CodeQL #81. The .replace() originally here only replaced the first occurrence of double-backslashes. Using a regex with a global flag option ensures all of the \\'s are replaced with /.

@mdtro mdtro requested review from a team, mydea and lforst and removed request for a team January 25, 2023 18:48
@Lms24 Lms24 added the CI-Overhead-Measurements Add this label to run SDK overhead measurements on a PR label Jan 25, 2023
@github-actions
Copy link
Contributor

Replay SDK metrics 🚀

Latest data for: 3a3b17d
  Plain +Sentry +Replay
Value Value Diff Ratio Value Diff Ratio
LCP 72.18 ms 94.77 ms +22.59 ms +31.29 % 118.45 ms +46.28 ms +64.11 %
CLS 0.02 ms 0.02 ms +0.00 ms +1.33 % 0.02 ms +0.00 ms +2.26 %
CPU 17.87 % 17.80 % -0.07 pp -0.38 % 31.30 % +13.44 pp +75.21 %
JS heap avg 1.73 MB 2.14 MB +405.77 kB +23.45 % 3.32 MB +1.59 MB +91.79 %
JS heap max 1.89 MB 2.35 MB +459.4 kB +24.25 % 4.48 MB +2.58 MB +136.29 %

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 25 Jan 2023 19:04:54 GMT

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing :)

@Lms24 Lms24 enabled auto-merge (squash) January 25, 2023 19:16
@Lms24 Lms24 merged commit a591f51 into master Jan 25, 2023
@Lms24 Lms24 deleted the mdtro/codeql-81 branch January 25, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Overhead-Measurements Add this label to run SDK overhead measurements on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants