Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeql(config): fix workflow on ignored .md files #6933

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Jan 25, 2023

CodeQL was not running on pull requests targeting the master branch. 🙂

Using a ! in the paths directive requires us to list another path without it to work properly in this case.(docs here). Since we are only looking to exclude the path, I've opted to switch us to use paths-ignore.

@mdtro mdtro requested review from a team, Lms24 and AbhiPrasad and removed request for a team January 25, 2023 18:47
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, didn't know that paths-ignore existed. And good catch about CodeQL, thanks!

@Lms24 Lms24 merged commit 040ab0c into master Jan 25, 2023
@Lms24 Lms24 deleted the mdtro/codeql-workflow-fix branch January 25, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants