Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(browser): Add
captureUserFeedback
#7729feat(browser): Add
captureUserFeedback
#7729Changes from 6 commits
1407448
314b615
a0394a0
e295944
6b8b10c
f29a85f
2c5aae5
631d858
d30527c
31c54c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's times like this I wish
client.sendEnvelope
was exposed - @lforst do you think we should just expose it?m: We can only call
transport.send
ifclient.getOptions().enabled !== false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling this should be checked in a more central location. Doesn't have to be this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably? It seems safer that this whole chain of grabbing stuff off the hub that may or may not be there. But honestly
sendEnvelope
seems a bit too low-level to just expose it on a pretty public place.I vote we take the bundle size hit and go ahead and implement user feedback like we implemented sessions, errors, and transactions just to stay consistent - meaning we put it as a
captureUserFeedback()
method on the (browser-)client.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me @krystofwoldrich - sorry for making you revert your work, but let's just add the methods to the browser client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind either, but the stand-alone function is a bit easier for reuse in other JS SDKs,
if we implement it on the Browser client we have to export the user feedback envelope creator for other JS-based SDKs,
if we would implement it as a standalone function other JS SDKs can use the method right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both electron and react native wrap browser - so it's only the node SDKs that won't have access to this, and I think that is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that's fair not that many SDKs, just a note RN doesn't wrap Browser.