Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consistent array syntax #227

Merged
merged 2 commits into from
Apr 11, 2019
Merged

chore: consistent array syntax #227

merged 2 commits into from
Apr 11, 2019

Conversation

chuangbo
Copy link
Contributor

No description provided.

@stayallive
Copy link
Collaborator

@chuangbo there are a lot of missed array() syntaxes left, not just in this file.

Would be nice to clean them up all at once if possible!?

@chuangbo
Copy link
Contributor Author

@stayallive sure will do

stayallive
stayallive approved these changes Apr 11, 2019
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 😄!

@stayallive stayallive merged commit 70b42a3 into getsentry:master Apr 11, 2019
@chuangbo chuangbo deleted the patch-1 branch April 11, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuangbo @stayallive