Fix events generated in queue worker not sending #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Sentry/Laravel/EventHandler.php
# Conflicts: # src/Sentry/Laravel/EventHandler.php
HazAT
reviewed
Apr 23, 2019
| { | ||
| $client = Hub::getCurrent()->getClient(); | ||
|
|
||
| if ($client instanceof Client) { |
There was a problem hiding this comment.
We should implement close/flush in the main SDK, this should make this obsolete.
This code should go directly in there.
There was a problem hiding this comment.
@HazAT yes, we had extensive discussion about it and the consensus is we made a mistake implementing the async stuff, so this is a workaround until we can fix that in the base SDK 👍 this will be removed at a later time since it won't be needed if fixed in the base SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround until we are able to restructure / fix the underlying issue in the client and our inability to wait for all events to be sent (or make sure they are sent immediately instead of waiting for a
waitcall, context getsentry/sentry-php#799).The scope popping was also not happening correctly because the
JobProcessedevent is only fired when a job is successfully handled. Another event is dispatched when an error occurs but the exception is logged after those events fire, thus the scope will already be popped once the exception is recorded, making the scope effectively useless./fixes #222