Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sentryMonitor macro chainable #705

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: Make sentryMonitor macro chainable #705

merged 1 commit into from
May 31, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented May 31, 2023

To make the macro chainable, we need to return $this.

    $schedule->command('do:stuff')
        ->everyMinute()
        ->sentryMonitor('do-stuff-monitor')
        ->withoutOverlapping();

Would throw Call to a member function withoutOverlapping() on null otherwise.

Followup for #698

@cleptric cleptric self-assigned this May 31, 2023
@cleptric cleptric merged commit a95c0c7 into master May 31, 2023
@cleptric cleptric deleted the chainable-macro branch May 31, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants