Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metric normalization #1729

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Update metric normalization #1729

merged 6 commits into from
Apr 10, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Apr 3, 2024

@cleptric cleptric self-assigned this Apr 3, 2024
@cleptric
Copy link
Member Author

cleptric commented Apr 3, 2024

@stayallive When you look at the linked docs, regarding Line Feed, Carriage Return and Tab.
I don't think you can use these characters in PHP. Or can you?

@stayallive
Copy link
Collaborator

You can right... "\n\r\t" (only inside ")?

So technically you can, but it's a stretch anyone would do it on purpose. But should also be easy to replace right? Something like str_replace(["\n", "\r", ...], ['\n', '\r', ...], $item) I'm thinking?

@cleptric cleptric marked this pull request as ready for review April 10, 2024 11:59
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks good!

@cleptric cleptric merged commit 1f26c26 into master Apr 10, 2024
31 checks passed
@cleptric cleptric deleted the metric-normalization branch April 10, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics Normalization
3 participants