-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed check for exclude #958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, but we're still internally discussing this and how to proceed.
This PR restores the behavior described in the unified APIs, and makes it easy to include the whole project, and exclude vendor
, which should be the most common case; OTOH though it makes impossible to do the reverse, like including a dependency inside vendor
(maybe an internal dependency?).
Thank you for the contribution, however this as-is cannot be merged because Unified API docs clearly says that
|
I would like to clarify this sentence because I feel that it's not: the behavior described in the Unified API is that the |
So before I set project_root = /app and excluded /app/vendor, now I have to mention all folders to include (/app/src, /app/bin, /app/tests and don't use app_exclude) |
Let's look to the code
If you say $projectRoot is deprecated then |
@ste93cry any comments? |
So, there is indeed one bug that should be addressed here:
With this behavior it's possible to include everything by default, exclude some folders (e.g. |
509b421
to
3387acf
Compare
@ste93cry I fixed default value for isInApp if in_app_include is not specified. |
As I said above, the default value of |
e6c474a
to
4659550
Compare
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. This one solves my issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to make this PR 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a changelog entry!
4659550
to
09d9bea
Compare
09d9bea
to
a8b303b
Compare
Updated changelog |
#953