Skip to content

Conversation

Perlence
Copy link
Contributor

The original type hint could be understood as a one-level dict of str to Any, when in fact, it's a two-level dict.

…exts"

The original type hint could be understood as a one-level `dict` of
`str` to `Any`, when in fact, it's a two-level dict.
@antonpirker antonpirker added the Trigger: tests using secrets PR code is safe; run CI label Feb 20, 2025
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution @Perlence!

@antonpirker antonpirker enabled auto-merge (squash) February 20, 2025 12:37
@antonpirker antonpirker merged commit 4d64c4e into getsentry:master Feb 20, 2025
141 of 143 checks passed
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (a3b6e5d) to head (a5cc928).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4080      +/-   ##
==========================================
- Coverage   79.57%   79.53%   -0.04%     
==========================================
  Files         140      140              
  Lines       15512    15512              
  Branches     2628     2628              
==========================================
- Hits        12343    12338       -5     
- Misses       2335     2337       +2     
- Partials      834      837       +3     
Files with missing lines Coverage Δ
sentry_sdk/scope.py 85.53% <ø> (ø)

... and 2 files with indirect coverage changes

@Perlence Perlence deleted the contexts-typing branch February 20, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants