Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Unify datetime format #2409

Merged
merged 15 commits into from
Nov 8, 2023
Merged

Conversation

mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Oct 3, 2023

This is a preliminary work to later add an API that allows metrics emission as part of span creation. This somewhat unifies the APIs with regards to timestamps. The span system uses datetime objects, this now also permits these values in metrics and vice versa.

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the end_timestamp in finish() to allow floats too, to be consistent

@mitsuhiko mitsuhiko changed the title feat(metrics): Allow metrics emission for spans feat(metrics): Unify datetime format Nov 6, 2023
@mitsuhiko mitsuhiko marked this pull request as ready for review November 6, 2023 15:41
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@antonpirker antonpirker enabled auto-merge (squash) November 6, 2023 15:51
@antonpirker antonpirker self-assigned this Nov 6, 2023
@antonpirker antonpirker merged commit 36c2650 into master Nov 8, 2023
310 of 312 checks passed
@antonpirker antonpirker deleted the feature/span-metrics branch November 8, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants