Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct data in check_ins #2500

Merged
merged 18 commits into from
Nov 13, 2023
Merged

Conversation

antonpirker
Copy link
Member

Make sure that breadcrumbs are not in check-ins.

Fixes #2496

sentry_sdk/scope.py Outdated Show resolved Hide resolved
tests/test_crons.py Outdated Show resolved Hide resolved
tests/test_crons.py Show resolved Hide resolved
@antonpirker antonpirker marked this pull request as ready for review November 10, 2023 14:35
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one comment, else LGTM!

sentry_sdk/scope.py Outdated Show resolved Hide resolved
@antonpirker antonpirker enabled auto-merge (squash) November 13, 2023 08:34
@antonpirker antonpirker merged commit 338acda into master Nov 13, 2023
314 checks passed
@antonpirker antonpirker deleted the antonpirker/correct-check-ins branch November 13, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkins are dropped when lots of Celery child tasks are started and max-tasks-per-child is reached
3 participants