Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): Do not wait for flusher thread to join #2707

Closed
wants to merge 4 commits into from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Feb 5, 2024

Under uWSGI the metrics flusher thread doesn't join properly, hanging on acquiring an internal lock. At the point where we try to join we've already stopped the thread's loop by setting _running to False, and we don't explicitly need to wait for the thread to terminate.

This mirrors what we do in the BackgroundWorker, where we also don't explicitly join.

Closes #2699


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review February 5, 2024 14:31
@sentrivana sentrivana enabled auto-merge (squash) February 6, 2024 08:19
@sentrivana
Copy link
Contributor Author

Merged as part of #2694

@sentrivana sentrivana closed this Feb 6, 2024
@sentrivana sentrivana deleted the ivana/fix-metrics-in-uwsgi branch February 6, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uWSGI workers dying in 1.40.0
4 participants