feat(perf): Add ability to put measurements directly on spans. #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-sentry
changed the title
Zylphrex
reviewed
Apr 10, 2024
Zylphrex
approved these changes
Apr 11, 2024
antonpirker
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Yes, looks OK.
But please do not merge for now. (Would make our live easier in case we need to fix something in SDK 2.0 that is discovered while dogfooding the SDK 2.0rc5 in sentry.io itself. We want to dog food until next week and then make the final 2.0 release)
|
Sorry for the wait folks! As 2.0 is out now, we're back to business so merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is already in other SDKs, and will be used in future AI features.