Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scope-span management #3472

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

sentrivana
Copy link
Contributor

  • Do not explicitly create a new_scope on start_span -- we already do this via the OTel context hook
  • Deprecate Scope.transaction and add Scope.root_span instead
  • Save span on scope -- a lot of code depends on the scope having a span set

Copy link

codecov bot commented Aug 28, 2024

❌ 3904 Tests Failed:

Tests completed Failed Passed Skipped
16683 3904 12779 1916
View the top 3 failed tests by shortest run time
tests.integrations.celery.test_celery test_abstract_task[<lambda>1]
Stack Traces | 0s run time
No failure message available
tests.integrations.celery.test_celery test_transaction_events[<lambda>3-success]
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this for now but I need to think through all the state flow end to end later. Basically all references should flow from the otel context so I might clean up spaghetti that is not required.

@sentrivana sentrivana merged commit f980b97 into potel-base Aug 29, 2024
9 of 108 checks passed
@sentrivana sentrivana deleted the ivana/potel/set-span-on-scope branch August 29, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants