Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and officially support hermes engine on iOS #1262

Closed
jennmueng opened this issue Dec 26, 2020 · 4 comments
Closed

Investigate and officially support hermes engine on iOS #1262

jennmueng opened this issue Dec 26, 2020 · 4 comments
Assignees
Labels
Platform: Cocoa up-for-grabs ✋ We would really appreciate anyone interested in working on this to submit a PR!

Comments

@jennmueng
Copy link
Member

jennmueng commented Dec 26, 2020

Support for hermes on iOS was just added in React Native 0.64-rc2 as an opt-in feature, we should investigate this and ensure our SDK fully supports it. We’ve had issues with hermes source maps in the past with Android, now that hermes is being extended to iOS we should ensure that there won’t be any issues.

@janicduplessis
Copy link
Contributor

I’m currently using it and it just worked without any changes needed

@jennmueng
Copy link
Member Author

So far it doesn't work for me, sending an event gets:

 Sentry Logger [Error]: SentryError: Event processing pipeline threw an error, original event will not be sent. Details have been sent as a new event. Reason: TypeError: undefined is not a function

@bruno-garcia bruno-garcia added the up-for-grabs ✋ We would really appreciate anyone interested in working on this to submit a PR! label Jan 4, 2021
@jennmueng
Copy link
Member Author

The error I mentioned in my previous comment that caused Sentry to not send events at all in 0.64 will be fixed by #1274. Next step is to investigate source maps from iOS Hermes

@jennmueng
Copy link
Member Author

So far none of the issues that I have run into have been related to Hermes but rather unrelated things such as #1274. So I will close this issue for now.

Please reopen/let us know if you run into any issues with Hermes on iOS.

@bruno-garcia bruno-garcia unpinned this issue Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Cocoa up-for-grabs ✋ We would really appreciate anyone interested in working on this to submit a PR!
Projects
None yet
Development

No branches or pull requests

3 participants