Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply Scope's transaction name if it's empty #1546

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Don't apply Scope's transaction name if it's empty #1546

merged 2 commits into from
Aug 21, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 21, 2021

Fixes #1540.

@st0012 st0012 added this to the 4.7.0 milestone Aug 21, 2021
@st0012 st0012 self-assigned this Aug 21, 2021
@st0012 st0012 added this to In progress in 4.x via automation Aug 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #1546 (1e1b46f) into master (af9803a) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1546      +/-   ##
==========================================
+ Coverage   97.89%   98.25%   +0.36%     
==========================================
  Files         222      127      -95     
  Lines       10833     7001    -3832     
==========================================
- Hits        10605     6879    -3726     
+ Misses        228      122     -106     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transaction_spec.rb 100.00% <100.00%> (ø)
sentry-raven/lib/raven/instance.rb
sentry-raven/lib/raven/utils/real_ip.rb
sentry-raven/spec/raven/utils/request_id_spec.rb
sentry-raven/lib/raven/integrations/sidekiq.rb
sentry-raven/spec/raven/linecache_spec.rb
...ntry-raven/lib/raven/core_ext/object/duplicable.rb
...y-raven/lib/raven/integrations/rails/active_job.rb
sentry-raven/spec/raven/instance_spec.rb
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9803a...1e1b46f. Read the comment docs.

@st0012 st0012 changed the title Don't apply Scope's transaction name to the event if it already has one Don't apply Scope's transaction name if it's empty Aug 21, 2021
@st0012 st0012 merged commit 3ddb146 into master Aug 21, 2021
4.x automation moved this from In progress to Done Aug 21, 2021
@st0012 st0012 deleted the fix-#1540 branch August 21, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

Sentry.start_transaction with name not work correctly
2 participants