Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct license of new SDK gems #1554

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Correct license of new SDK gems #1554

merged 3 commits into from
Sep 1, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 28, 2021

Keep the old sentry-raven with Apache-2, but new gems should be MIT.

@timhaines
Copy link

Thanks @st0012! 💯

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given that the repo is Apache 2: https://github.com/getsentry/sentry-ruby/blob/master/LICENSE

Copy link
Member

@mitsuhiko mitsuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the desire was for this to be MIT licensed.

@st0012 st0012 requested a review from mitsuhiko August 30, 2021 12:47
@st0012 st0012 changed the title Correct license files of new SDK gems Correct license of new SDK gems Aug 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #1554 (553cbc7) into master (b285753) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
+ Coverage   97.92%   98.29%   +0.37%     
==========================================
  Files         222      127      -95     
  Lines       10867     7030    -3837     
==========================================
- Hits        10641     6910    -3731     
+ Misses        226      120     -106     
Impacted Files Coverage Δ
...en/spec/raven/integrations/rails/activejob_spec.rb
...ntry-raven/spec/raven/processors/post_data_spec.rb
...-raven/spec/raven/integrations/rails/event_spec.rb
sentry-raven/lib/raven/integrations/delayed_job.rb
sentry-raven/spec/raven/utils/real_ip_spec.rb
sentry-raven/spec/raven/transports/http_spec.rb
sentry-raven/spec/raven/integrations/rack_spec.rb
sentry-raven/lib/raven/transports/dummy.rb
sentry-raven/spec/raven/integrations/rails_spec.rb
...ntry-raven/lib/raven/processor/removestacktrace.rb
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b285753...553cbc7. Read the comment docs.

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could make LICENSE a symlink to sentry-ruby/LICENSE.txt, similar to how README is a symlink.
By removing the file I'm afraid it will remove the license information that GitHub publishes about the repo:

image

@st0012
Copy link
Collaborator Author

st0012 commented Aug 30, 2021

@rhcarvalho 👍 updated

@bruno-garcia
Copy link
Member

bruno-garcia commented Aug 30, 2021

Shouldn't those be licensed to sentry? It's with your github handle

The MIT License (MIT)

Copyright (c) 2020 st0012

@st0012
Copy link
Collaborator Author

st0012 commented Aug 31, 2021

@bruno-garcia good catch 👍 all updated

@st0012
Copy link
Collaborator Author

st0012 commented Aug 31, 2021

@mitsuhiko may I merge this?

@st0012 st0012 merged commit 4e7eb21 into master Sep 1, 2021
@st0012 st0012 deleted the correct-license branch September 1, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants