Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sentry::Rails::CaptureExceptions before ActionDispatch::ShowExceptions #1608

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Nov 6, 2021

This can save us from reporting the exception manually in RescuedExceptionInterceptor, which was designed to prevent the exception being rescued by ShowExceptions.

This can save us from reporting the exception manually in
RescuedExceptionInterceptor, which was designed to prevent the exception
being rescued by ShowExceptions.
@st0012 st0012 added this to the 4.8.0 milestone Nov 6, 2021
@st0012 st0012 self-assigned this Nov 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #1608 (032e995) into master (81c0f81) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1608      +/-   ##
==========================================
- Coverage   98.45%   98.43%   -0.02%     
==========================================
  Files         130      130              
  Lines        7230     7221       -9     
==========================================
- Hits         7118     7108      -10     
- Misses        112      113       +1     
Impacted Files Coverage Δ
.../lib/sentry/rails/rescued_exception_interceptor.rb 85.71% <ø> (-5.60%) ⬇️
sentry-rails/lib/sentry/rails/railtie.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 95.65% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c0f81...032e995. Read the comment docs.

@st0012 st0012 merged commit 7a3a86b into master Nov 7, 2021
@st0012 st0012 deleted the simplify-sentry-rails-exception-handling-chain branch November 7, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants