Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly return JobClass#perform's return value #1667

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 5, 2022

Fixes #1666

@st0012 st0012 added this to the 4.9.0 milestone Jan 5, 2022
@st0012 st0012 self-assigned this Jan 5, 2022
@davidwessman
Copy link

Thank you! Took the same time for me to refactor our use of the return value 🙂

@st0012 st0012 changed the base branch from master to 4-8 January 5, 2022 10:12
@st0012 st0012 changed the base branch from 4-8 to master January 5, 2022 10:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1667 (d2457c8) into master (4c0be87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1667   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         136      136           
  Lines        7656     7664    +8     
=======================================
+ Hits         7539     7547    +8     
  Misses        117      117           
Impacted Files Coverage Δ
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/activejob_spec.rb 99.29% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0be87...d2457c8. Read the comment docs.

@st0012
Copy link
Collaborator Author

st0012 commented Jan 5, 2022

@davidwessman No problem. Thank you for reporting the issue 😄
I'll need to sync changes between master and 4-8 branch though so it could take a bit longer to patch out a new version.

@st0012 st0012 mentioned this pull request Jan 5, 2022
@st0012 st0012 merged commit 1c62438 into master Jan 5, 2022
@st0012 st0012 deleted the fix-#1666 branch January 5, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 4.8.2: ActiveJobs return nil even if they have a return value
3 participants