Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request env to sampling context #1749

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Add request env to sampling context #1749

merged 2 commits into from
Mar 3, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Feb 27, 2022

Closes #1732

@st0012 st0012 added this to the 5.2.0 milestone Feb 27, 2022
@st0012 st0012 self-assigned this Feb 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2022

Codecov Report

Merging #1749 (a4675ab) into master (d679277) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
+ Coverage   98.39%   98.41%   +0.01%     
==========================================
  Files         141      141              
  Lines        8046     8052       +6     
==========================================
+ Hits         7917     7924       +7     
+ Misses        129      128       -1     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/rack/capture_exceptions.rb 95.00% <100.00%> (ø)
...y-ruby/spec/sentry/rack/capture_exceptions_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 96.29% <0.00%> (-3.71%) ⬇️
sentry-ruby/lib/sentry/background_worker.rb 100.00% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d679277...a4675ab. Read the comment docs.

@st0012
Copy link
Collaborator Author

st0012 commented Feb 27, 2022

@sl0thentr0py I think having the entire request env can enable the most flexible sampling logic? Since the sampling context should be tossed away right after the sampling is done, I don't see any obvious issue for it. Do you have any concern on this?

@sl0thentr0py
Copy link
Member

@st0012 yeah that's perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add request info to custom_sampling_context in rack middleware
3 participants