Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if any integration is required after SDK initialization #1759

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Mar 12, 2022

Fixes #1756

@st0012 st0012 added this to the 5.3.0 milestone Mar 12, 2022
@st0012 st0012 self-assigned this Mar 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #1759 (a50ae0f) into master (df531f0) will increase coverage by 2.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
+ Coverage   96.40%   98.47%   +2.06%     
==========================================
  Files         119      144      +25     
  Lines        7169     8436    +1267     
==========================================
+ Hits         6911     8307    +1396     
+ Misses        258      129     -129     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 95.94% <100.00%> (+0.08%) ⬆️
sentry-ruby/spec/sentry/integrable_spec.rb 100.00% <100.00%> (ø)
sentry-resque/lib/sentry/resque.rb 97.14% <0.00%> (-2.86%) ⬇️
...ry/rails/tracing/active_storage_subscriber_spec.rb 100.00% <0.00%> (ø)
sentry-rails/spec/sentry/rails/activejob_spec.rb 99.37% <0.00%> (ø)
sentry-rails/spec/dummy/test_rails_app/apps/6-1.rb 100.00% <0.00%> (ø)
sentry-rails/spec/sentry/rails/event_spec.rb 100.00% <0.00%> (ø)
...rails/tracing/action_controller_subscriber_spec.rb 100.00% <0.00%> (ø)
...ntry-rails/spec/sentry/rails/configuration_spec.rb 100.00% <0.00%> (ø)
...ry/rails/breadcrumbs/active_support_logger_spec.rb 100.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df531f0...a50ae0f. Read the comment docs.

@st0012 st0012 merged commit 30d6500 into master Mar 14, 2022
@st0012 st0012 deleted the fix-#1756 branch March 14, 2022 10:42
@st0012 st0012 modified the milestones: 5.3.0, 5.2.1 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error if sentry-sidekiq is imported after Sentry.init
3 participants