Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release detector: Use full SHA hash in default release name #2174

Merged

Conversation

natikgadzhi
Copy link
Contributor

Summary

This pull request makes it so Sentry-Ruby will name releases by their full SHA commit hash instead of the short version.

/cc @sl0thentr0py and @stephanie-anderson

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #2174 (dbc5f3f) into master (c7c8e5b) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2174      +/-   ##
==========================================
- Coverage   97.40%   97.37%   -0.03%     
==========================================
  Files          98       98              
  Lines        3655     3655              
==========================================
- Hits         3560     3559       -1     
- Misses         95       96       +1     
Components Coverage Δ
sentry-ruby 98.02% <100.00%> (ø)
sentry-rails 94.98% <ø> (ø)
sentry-sidekiq 95.54% <ø> (ø)
sentry-resque 92.06% <ø> (-1.59%) ⬇️
sentry-delayed_job 94.36% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/release_detector.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sl0thentr0py sl0thentr0py merged commit 16ef3e7 into getsentry:master Nov 23, 2023
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic release detection naming conflict with Github Action
2 participants