This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
fix(ci): Increase stack size in errors #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-longer-stacktraces-in-ci
branch
2 times, most recently
from
ae502d0
to
3532c04
Compare
kamilogorek
approved these changes
Oct 1, 2021
iker-barriocanal
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, node limits stacktraces to 10 lines. That's often not enough to tell what's gone wrong, especially when dealing with async code (which can add many frames just handling its own asynciness). For example, when trying to release this plugin, I ran into this:
What's wrong? How do I fix it? No way to know.
Fortunately, node allows you to increase that limit, and since version 8, has further allowed you to specify global options via the
NODE_OPTIONSenvironment variable. This PR does both, for all ci processes where we own the code that's being run.Before:
After: