Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the hydration breadcrumbs to display a modal with a diff #61613

Closed
Tracked by #59564
scttcper opened this issue Dec 12, 2023 · 0 comments · Fixed by #61477
Closed
Tracked by #59564

Use the hydration breadcrumbs to display a modal with a diff #61613

scttcper opened this issue Dec 12, 2023 · 0 comments · Fixed by #61477

Comments

@scttcper
Copy link
Member

No description provided.

This was referenced Dec 12, 2023
Open
Merged
ryan953 added a commit that referenced this issue Dec 13, 2023
@ryan953 @scttcper
feat(replay): Visually compare & diff react hydration errors on the R…
7dea10a 
…eplay Details page (#61477)

Reads the new `session-replay-show-hydration-errors` feature flag which
controls if we show `replay.hydrate-error` crumbs on the Replay Details
page.

These crumbs have a poor design right now, but they have a button which
will open a Modal that shows a visual side-by-side comparison of before
& after the hydration error happened. Also, it shows a diff of the html.

<img width="1426" alt="SCR-20231208-ninr"
src="https://github.com/getsentry/sentry/assets/187460/2b5b172d-024d-4535-98d9-86493405c523">


Depends on #61612
See related SDK change:
getsentry/sentry-javascript#9759

fixes #61613

---------

Co-authored-by: Scott Cooper <scttcper@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@scttcper