feat(replay): Visually compare & diff react hydration errors on the Replay Details page #61477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
changed the title
ryan953
changed the title
scttcper
approved these changes
Dec 12, 2023
billyvg
reviewed
Dec 12, 2023
| replay={replay} | ||
| initialTimeOffsetMs={{offsetMs: leftTimestamp - 1}} | ||
| > | ||
| <div id="leftSide" style={{display: 'contents', width: '50%'}}> |
There was a problem hiding this comment.
Let's get rid of the inline styles
ryan953
added a commit
that referenced
this pull request
Dec 12, 2023
ryan953
commented
Dec 13, 2023
|
|
||
| return ( | ||
| <CrumbItem | ||
| as={onClick ? 'button' : 'span'} | ||
| as={onClick && !forceSpan ? 'button' : 'span'} |
There was a problem hiding this comment.
fix that nesting issue i see
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads the new
session-replay-show-hydration-errorsfeature flag which controls if we showreplay.hydrate-errorcrumbs on the Replay Details page.These crumbs have a poor design right now, but they have a button which will open a Modal that shows a visual side-by-side comparison of before & after the hydration error happened. Also, it shows a diff of the html.
Depends on #61612
See related SDK change: getsentry/sentry-javascript#9759
fixes #61613