Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Create a feature flag session-replay-show-hydration-errors #61612

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Dec 12, 2023

See also: #61477

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 12, 2023
@ryan953 ryan953 requested review from scttcper and a team December 12, 2023 18:34
@ryan953 ryan953 enabled auto-merge (squash) December 12, 2023 18:45
@ryan953 ryan953 merged commit 826538a into master Dec 12, 2023
51 checks passed
@ryan953 ryan953 deleted the ryan953/replay-hydration-feature branch December 12, 2023 18:54
ryan953 added a commit that referenced this pull request Dec 13, 2023
…eplay Details page (#61477)

Reads the new `session-replay-show-hydration-errors` feature flag which
controls if we show `replay.hydrate-error` crumbs on the Replay Details
page.

These crumbs have a poor design right now, but they have a button which
will open a Modal that shows a visual side-by-side comparison of before
& after the hydration error happened. Also, it shows a diff of the html.

<img width="1426" alt="SCR-20231208-ninr"
src="https://github.com/getsentry/sentry/assets/187460/2b5b172d-024d-4535-98d9-86493405c523">


Depends on #61612
See related SDK change:
getsentry/sentry-javascript#9759

fixes #61613

---------

Co-authored-by: Scott Cooper <scttcper@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants