Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devenv: move legacy setup-git to sync #72870

Merged
merged 22 commits into from
Jul 10, 2024
Merged

devenv: move legacy setup-git to sync #72870

merged 22 commits into from
Jul 10, 2024

Conversation

joshuarli
Copy link
Member

@joshuarli joshuarli commented Jun 17, 2024

First step towards cleaning up all the legacy stuff. This moves setup-git to sync. context: https://github.com/getsentry/getsentry/pull/13540/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R28

Also removes the old make bootstrap and make develop now just runs devenv sync.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jun 17, 2024
@getsentry getsentry deleted a comment from github-actions bot Jun 17, 2024
@getsentry getsentry deleted a comment from github-actions bot Jun 17, 2024
@joshuarli joshuarli marked this pull request as ready for review June 17, 2024 17:58
@joshuarli joshuarli requested a review from a team as a code owner June 17, 2024 17:58
@joshuarli joshuarli requested a review from a team June 17, 2024 17:58
devenv/sync.py Outdated Show resolved Hide resolved
@joshuarli joshuarli changed the base branch from master to pre-commit-js-lints-take-2 July 1, 2024 14:10
@joshuarli joshuarli requested a review from a team July 1, 2024 14:10
@joshuarli joshuarli requested review from a team as code owners July 1, 2024 14:10
@getsentry getsentry deleted a comment from github-actions bot Jul 1, 2024
@getsentry getsentry deleted a comment from codecov bot Jul 1, 2024
@getsentry getsentry deleted a comment from codecov bot Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (f4df6e0) to head (0058bf9).
Report is 110 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72870      +/-   ##
==========================================
+ Coverage   78.10%   78.14%   +0.03%     
==========================================
  Files        6660     6656       -4     
  Lines      297707   297219     -488     
  Branches    51226    51127      -99     
==========================================
- Hits       232533   232265     -268     
+ Misses      58904    58701     -203     
+ Partials     6270     6253      -17     

see 101 files with indirect coverage changes

@getsentry getsentry deleted a comment from github-actions bot Jul 1, 2024
@getsentry getsentry deleted a comment from github-actions bot Jul 1, 2024
Base automatically changed from pre-commit-js-lints-take-2 to master July 8, 2024 22:10
Copy link
Contributor

github-actions bot commented Jul 8, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@joshuarli joshuarli merged commit 30757a6 into master Jul 10, 2024
52 checks passed
@joshuarli joshuarli deleted the devenv-sync-setup-git branch July 10, 2024 23:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants