build(webpack): Remove lodash-webpack-plugin
#15521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
force-pushed
the
build/webpack/remove-lodash-webpack-plugin
branch
3 times, most recently
from
fb89c8e
to
4cc2fbb
Compare
billyvg
force-pushed
the
build/webpack/remove-lodash-webpack-plugin
branch
from
0d16e27
to
6613a86
Compare
billyvg
changed the title
lodash-webpack-plugin [WIP]lodash-webpack-plugin
billyvg
force-pushed
the
build/webpack/remove-lodash-webpack-plugin
branch
from
6613a86
to
7bc1763
Compare
billyvg
force-pushed
the
build/webpack/remove-lodash-webpack-plugin
branch
from
7bc1763
to
d171663
Compare
|
@billyvg do we have an ES lint rule to prevent folks from importing the full lodash library? |
|
@scefali ya it's linked getsentry/eslint-config-sentry#46 |
scefali
approved these changes
Nov 13, 2019
jan-auer
added a commit
that referenced
this pull request
Nov 13, 2019
* master: (59 commits) fix(btn-group-break): quick fix for issues table nav items (#15585) feat(ui): Change `<SmartSearchBar>` to simulate "search" on En… (#15345) ref: Update semaphore to 0.4.61 (#15574) fix(api): Fix failing snuba test in Django 1.9 chore(ts): convert sentry app component files (#15575) build(github-actions): RIP github actions (#15577) feat(ui): Adapt user-feedback page to lightweight organization context (#15551) ref(logo replacement): converted pngs to svgs (#15552) Remove unused animated-ellipsis (#15515) fix: Fix `get_participants` to use `__in` correctly. build(webpack): Remove `lodash-webpack-plugin` (#15521) moved the bulk of plugins from test_only_plugins into new_sentry_plugins (#15468) ref: Remove "store.save-event-skips-nodestore" option from code (#15568) logging(app-context): adds more logging context for slack api errors (#15557) build(babel): Remove `@babel/polyfill` (#15564) chore(ts): convert sentryApps (#15565) chore(ts): convert SentryAppIcon (#15569) fix: Avoid updating with None (#15549) feat(api): Project key creation rate limit params (#15366) fix(api): Fix failing snuba test in Django 1.9 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoes the work in introduced in #5616.
This plugin adds around 40-50 seconds to webpack build times and has caused confusion (see #13834).
Currently, there is no sizable difference between
lodash-esandlodash-- we should revisit this in the future.