fix(auth): Associate org member on single-org register #18922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh the title of this is wrong lol |
evanpurkhiser
changed the title
BYK
approved these changes
May 22, 2020
…-on-singleorg-register
Sounds like a product question. @dcramer do we even want to support open registration in a multi org setup? |
evanpurkhiser
deleted the
evanpurkhiser/fixauth-associate-org-member-on-singleorg-register
branch
Why wouldn't we? There are companies running on-premise Sentry in multi-org mode. |
|
Fwiw multi org is more or less considered saas. I think multi org and open
reg is a future security report.
On Sat, May 23, 2020 at 1:11 AM Burak Yigit Kaya ***@***.***> wrote:
Sounds like a product question. @dcramer <https://github.com/dcramer> do
we even want to support open registration in a multi org setup?
Why wouldn't we? There are companies running on-premise Sentry in
multi-org mode.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18922 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFYOXZSY6OYSMCZBKD5RTRS6AMVANCNFSM4NFNIOLA>
.
--
Sent from my phone. Pardon the typos.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-18800.
I tried to dig into this a bit to understand how it broke, because I'm sure this was working before, but I can't seem to find the logic that had it working before..
I think this is the most straight forward for how this should work though.