Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(py3): Remove all six.PYx references #23195

Merged
merged 1 commit into from
Jan 22, 2021
Merged

ref(py3): Remove all six.PYx references #23195

merged 1 commit into from
Jan 22, 2021

Conversation

BYK
Copy link
Contributor

@BYK BYK commented Jan 20, 2021

No description provided.

@BYK BYK requested a review from a team as a code owner January 20, 2021 19:35
@BYK BYK requested a review from a team January 20, 2021 19:35
joshuarli
joshuarli approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@joshuarli joshuarli left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming comments are addressed.

Also looks like a bunch of pre-commit things to address.

@BYK BYK enabled auto-merge (squash) January 20, 2021 22:26
@BYK
Copy link
Contributor Author

BYK commented Jan 20, 2021

No idea why the test is failing, will investigate.

@joshuarli joshuarli mentioned this pull request Jan 22, 2021
Merged
@BYK BYK requested review from a team January 22, 2021 10:35
@BYK BYK requested review from a team as code owners January 22, 2021 10:35
@BYK BYK requested a review from a team January 22, 2021 10:35
@BYK BYK requested review from a team and removed request for a team January 22, 2021 10:40
@github-actions
Copy link
Contributor

size-limit report

Path Size
public/app.js 308.92 KB (added)
public/vendor.js 604.88 KB (added)
public/sentry.css 30.69 KB (added)

@BYK BYK merged commit fd6c938 into master Jan 22, 2021
@BYK BYK deleted the byk/ref/bye-six branch January 22, 2021 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser left review comments

@joshuarli joshuarli joshuarli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BYK @evanpurkhiser @joshuarli