ref(py3): pre-commit upgrade + sweeping rerun + __future__ removals

[joshuarli]

For anyone rebasing/merging against this when it lands, you'll need to make setup-git and run pre-commit on the files you changed in your branch. Something like pre-commit run --files $(git whatchanged --name-only --pretty="" master... | sort | uniq).

This upgrades pre-commit and its hooks, moves it into a requirements-pre-commit.txt for git hook notifications on updates, and reruns pre-commit on everything. Most notably, black's target-version py36 removes u prefixes. flake8 is now run on bin/ and I manually made those fixes. Also removes all __future__s (in our case we can remove everything).

[joshuarli]

Sorry for the notifications, codeowners. lol

[untitaker]

unsubscribe

[billyvg]

Do we need to do this for getsentry as well?

[joshuarli]

I'm probably going to wait for #23195. @wedamija would also like your review on https://github.com/getsentry/getsentry/pull/4957.

[joshuarli]

Oh, might as well just remove all the __future__s. All the ones we have are not necessary in Python 3.6, you can refer to Python's Lib/__future__.py.

[joshuarli]

git fetch origin
git merge -Xtheirs origin/master
manually remove any files marked as UD (deleted upstream)
...let pre-commit run on the merge commit, or if there wasn't a pause,
pre-commit run --files $(git diff --name-only HEAD~1 HEAD)

[joshuarli]

Ah backend lint cancelled at 3 min cap... @billyvg FYI this did not result in a "failure", I had to notice this.

Bumping to 10 for now.

[billyvg]

Ah backend lint cancelled at 3 min cap... @billyvg FYI this did not result in a "failure", I had to notice this.

Bumping to 10 for now.

Yeah cancelled jobs have a subtle gray icon but will count as a failure if the check is required (which can't happen on gs)

[joshuarli]

lol

reformatted /Users/joshua.li/dev/sentry/sentry/src/sentry/migrations/0150_remove_userreport_eventattachment_constraints.py

examples/oauth2_consumer_webserver/app.py:1:1: B317: Use ``from sentry.utils import json`` instead.

but other than this we lookin' good, gonna wait until monday, remerge, and do all of this for https://github.com/getsentry/getsentry/pull/4957

[joshuarli]

Uhh, lol, guess I went at it too hard today.

Fetching list of changed files for PR#23197 from Github API
Error: API rate limit exceeded for installation ID 1204373.