Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(js): Refactor OrganizationGeneralSettings #28704

Merged
merged 1 commit into from
Sep 21, 2021
Merged

ref(js): Refactor OrganizationGeneralSettings #28704

merged 1 commit into from
Sep 21, 2021

Conversation

evanpurkhiser
Copy link
Member

  • Functional component
  • Remove usage of organization.projects (in favor of withProjects)

@evanpurkhiser
ref(js): Refactor OrganizationGeneralSettings
f42a739 
 - Functional component
 - Remove usage of organization.projects (in favor of withProjects)
@evanpurkhiser evanpurkhiser requested a review from a team September 20, 2021 23:47
@evanpurkhiser evanpurkhiser requested a review from a team September 20, 2021 23:47
matejminar
matejminar approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, lgtm.

@evanpurkhiser evanpurkhiser merged commit 24a65ae into master Sep 21, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-js-refactor-organizationgeneralsettings branch September 21, 2021 06:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matejminar matejminar matejminar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @matejminar