Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platforms): Add Svelte as a platform #37909

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 17, 2022

This PR adds Svelte as a platform, following the alpha release of our Svelte SDK.

Our SDK docs (getsentry/sentry-docs#5413)

Ref and SDK Roadmap: getsentry/sentry-javascript#5492 getsentry/sentry-javascript#5671

@Lms24 Lms24 self-assigned this Aug 17, 2022
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 17, 2022
@Lms24 Lms24 marked this pull request as ready for review August 17, 2022 13:15
@Lms24 Lms24 requested a review from a team as a code owner August 17, 2022 13:15
@Lms24 Lms24 requested a review from AbhiPrasad August 17, 2022 13:15
@Neo-Zhixing
Copy link
Contributor

Hey! Can you update to master and update the platform_categories.py file on the backend as well?
#37894

@Lms24
Copy link
Member Author

Lms24 commented Aug 19, 2022

Sure @Neo-Zhixing will do. Should this go into a separate PR (as it is a backend change)?

add platform entries and links to Svelte docs
@Lms24 Lms24 force-pushed the feature/lms-svelte-platform branch from aa3342a to 91495a2 Compare September 1, 2022 10:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@Lms24
Copy link
Member Author

Lms24 commented Sep 1, 2022

@Neo-Zhixing opened a separate PR for the backend change (#38379)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants