fix(ui): Adjust sizing of page filter components to prevent overflow in more cases #41979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
commented
Dec 2, 2022
| @@ -37,7 +37,7 @@ const PageFilterBar = styled('div')<{condensed?: boolean}>` | |||
| } | |||
|
|
|||
| & > * { | |||
| min-width: 6rem; | |||
| min-width: 7rem; | |||
There was a problem hiding this comment.
Increasing this to 7rem ensures that 24h and other 3 character time range selections don't overflow
malwilley
force-pushed
the
malwilley/fix/page-filter-overflow
branch
from
a02fdc4
to
2f85e92
Compare
malwilley
commented
Dec 2, 2022
| @@ -80,7 +80,7 @@ type Props = { | |||
|
|
|||
| function ProjectPageFilter({ | |||
| specificProjectSlugs, | |||
| maxTitleLength = 30, | |||
| maxTitleLength = 25, | |||
There was a problem hiding this comment.
Decreased this from 30 to 25 because it was taking up too much of the maximum 30rem width allowed by the page filter bar.
vuluongj20
approved these changes
Dec 5, 2022
…t where overflow occurred
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41932
Before:
After: