Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(segmentedControl): Fix text ellipsization #44131

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix(segmentedControl): Fix text ellipsization #44131

merged 1 commit into from
Feb 3, 2023

Conversation

vuluongj20
Copy link
Member

The change made in #44075 broke text ellipsization. This PR fixes it.

Before ——
Screenshot 2023-02-03 at 1 55 46 PM

After ——
Screenshot 2023-02-03 at 1 55 27 PM

@vuluongj20 vuluongj20 requested a review from a team as a code owner February 3, 2023 21:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 3, 2023
@vuluongj20 vuluongj20 mentioned this pull request Feb 3, 2023
Closed
14 tasks
evanpurkhiser
evanpurkhiser approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css css css css css css css css css css css css css css css css css css css css css css css css

@vuluongj20 vuluongj20 merged commit 70800f5 into master Feb 3, 2023
@vuluongj20 vuluongj20 deleted the vl/segmented-control-ellipsis branch February 3, 2023 22:33
mikejihbe pushed a commit that referenced this pull request Feb 6, 2023
@vuluongj20 @mikejihbe
fix(segmentedControl): Fix text ellipsization (#44131)
8353979 
The change made in #44075 broke
text ellipsization. This PR fixes it.

**Before ——**
<img width="433" alt="Screenshot 2023-02-03 at 1 55 46 PM"
src="https://user-images.githubusercontent.com/44172267/216718501-faff4810-e4b1-4491-9ff6-808c04da1aa1.png">

**After ——**
<img width="433" alt="Screenshot 2023-02-03 at 1 55 27 PM"
src="https://user-images.githubusercontent.com/44172267/216718543-8f737a27-7878-409d-bfc0-1ce7cf6de5c9.png">
wmak pushed a commit that referenced this pull request Feb 16, 2023
@vuluongj20 @wmak
fix(segmentedControl): Fix text ellipsization (#44131)
3f43175 
The change made in #44075 broke
text ellipsization. This PR fixes it.

**Before ——**
<img width="433" alt="Screenshot 2023-02-03 at 1 55 46 PM"
src="https://user-images.githubusercontent.com/44172267/216718501-faff4810-e4b1-4491-9ff6-808c04da1aa1.png">

**After ——**
<img width="433" alt="Screenshot 2023-02-03 at 1 55 27 PM"
src="https://user-images.githubusercontent.com/44172267/216718543-8f737a27-7878-409d-bfc0-1ce7cf6de5c9.png">
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuluongj20 @evanpurkhiser