fix(ui) Fix navigation between customer-domain accounts #44625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve navigation and subdomain support for `yarn dev-ui`. With these changes the following works: - https://acme.localhost:7999/issues/ - https://acme.dev.getsentry.net:7999/issues/ - https://acme.abc1243.sentry.dev/issues/ Switching between organizations will also work, as domains will be rewritten based on the initial page configuration. Users of dev-ui will still need to clone their session cookies and set host file entries if they want to use `acme.localhost` domains. Refs HC-429
github-actions
bot
added
the
Scope: Frontend
size-limit report 📦
|
static/app/utils/useResolveRoute.tsx
Outdated
| } | ||
| const host = window.location.host; | ||
| const validHostPattern = | ||
| /((?:localhost|[^.]+\.sentry\.dev|dev\.getsentry\.net)(?:\:\d*)?)/; |
There was a problem hiding this comment.
Should this be some kind of constant, we have a similar regex above
There was a problem hiding this comment.
The capturing groups are different between the patterns though. The one in useResolveRoute() needs to extract the slug, while this function needs to match the trailing domain + port.
I can try replacing the regex patterns with split on . operations.
evanpurkhiser
approved these changes
Feb 14, 2023
priscilawebdev
approved these changes
Feb 15, 2023
|
I can confirm that |
Yes when you clone your cookies into localhost make sure to set the domain attribute to |
wmak
pushed a commit
that referenced
this pull request
Feb 16, 2023
Improve navigation and subdomain support for `yarn dev-ui`. With these changes the following works: - https://acme.localhost:7999/issues/ - https://acme.dev.getsentry.net:7999/issues/ - https://acme.abc1243.sentry.dev/issues/ Switching between organizations will also work, as domains will be rewritten based on the initial page configuration. Users of dev-ui will still need to clone their session cookies and set host file entries if they want to use `acme.localhost` domains. Refs HC-429
jjbayer
added a commit
that referenced
this pull request
Feb 17, 2023
The change to `devServer.allowedHost` made in #44625 caused Relay to fail authentication in our dev setup: ``` relay 2023-02-16T15:42:01Z [relay_server::actors::upstream] INFO: registering with upstream (http://host.docker.internal:8000/) relay 2023-02-16T15:42:01Z [relay_server::actors::upstream] ERROR: authentication encountered error: could not send request relay caused by: failed to parse JSON response relay caused by: expected value at line 1 column 1 ``` because the dev server responded with the string `Invalid Host header`. I'm not sure why webpack is even in the loop for API requests, but adding the `.docker.internal` suffix to `allowedHosts` seems to fix the problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve navigation and subdomain support for
yarn dev-ui. With these changes the following works:Switching between organizations will also work, as domains will be rewritten based on the initial page configuration.
Users of dev-ui will still need to clone their session cookies and set host file entries if they want to use
acme.localhostdomains.Refs HC-429