ref(escalating-issues): Remove GroupForecast model #47593
Conversation
Step 2 of removing the GroupForecast table WOR-2966
github-actions
bot
added
the
Scope: Backend
Can you add into the description what step 1 was, and a link to the PR? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47593 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 4762 4761 -1
Lines 201424 201412 -12
Branches 11618 11618
=======================================
+ Hits 162654 162655 +1
+ Misses 38514 38501 -13
Partials 256 256
|
| operations = [ | ||
| migrations.DeleteModel( | ||
| name="GroupForecast", | ||
| ), | ||
| ] |
There was a problem hiding this comment.
This needs to be a state only operation for now. We just want to remove code references here, not the actual database table itself (that's step 3).
Even though this table is unused/empty, the problem here is that if you drop the table, then there's still code in production that thinks it exists. So if someone deletes a Group, then as part of that deletion django will attempt to query this table to see if there are any related rows that should be removed. Since the table doesn't exist, then we'll throw an exception and the deletion will fail.
There was a problem hiding this comment.
Thank you, I didn't notice it wasn't generated as state only
|
This PR has a migration; here is the generated SQL for --
-- Custom state/database change combination
-- |
Step 2 of removing the GroupForecast table
See step 1: removing the foreign key constraint in the GroupForecast table here
WOR-2966