-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(escalating-issues): Delete GroupForecast Table #47601
Conversation
Step 2 of removing the GroupForecast table WOR-2966
Step 3 of removing the GroupForecast table WOR-2966
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please make sure that this isn't merged until #47593 is merged + deployed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47601 +/- ##
===========================================
+ Coverage 59.09% 80.80% +21.71%
===========================================
Files 4728 4764 +36
Lines 200505 201167 +662
Branches 11605 11607 +2
===========================================
+ Hits 118483 162557 +44074
+ Misses 81766 38354 -43412
Partials 256 256 |
This PR has a migration; here is the generated SQL for --
-- Raw SQL operation
--
DROP TABLE "sentry_groupforecast";
; |
You'll need to delete these tests to get tests to pass: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That test failure should be unrelated... I'd try just rebasing on latest master
Was referring to this test failure: https://github.com/getsentry/sentry/actions/runs/4747748622/jobs/8433063906 |
Step 3 of removing the GroupForecast table
See step 2: removing the GroupForecast model here
See step 1: removing the foreign key constraint in the GroupForecast table here
WOR-2966