Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(escalating-issues): Delete GroupForecast Table #47601

Merged
merged 8 commits into from
Apr 20, 2023

Conversation

jangjodi
Copy link
Member

Step 3 of removing the GroupForecast table

See step 2: removing the GroupForecast model here
See step 1: removing the foreign key constraint in the GroupForecast table here

WOR-2966

@jangjodi jangjodi requested a review from a team as a code owner April 18, 2023 22:32
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 18, 2023
@jangjodi jangjodi requested a review from a team April 18, 2023 22:33
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please make sure that this isn't merged until #47593 is merged + deployed

Base automatically changed from jodi/wor-2966-remove-model to master April 19, 2023 20:05
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #47601 (97af7fa) into master (fe46cf7) will increase coverage by 21.71%.
The diff coverage is n/a.

❗ Current head 97af7fa differs from pull request most recent head 4812db3. Consider uploading reports for the commit 4812db3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #47601       +/-   ##
===========================================
+ Coverage   59.09%   80.80%   +21.71%     
===========================================
  Files        4728     4764       +36     
  Lines      200505   201167      +662     
  Branches    11605    11607        +2     
===========================================
+ Hits       118483   162557    +44074     
+ Misses      81766    38354    -43412     
  Partials      256      256               

see 1602 files with indirect coverage changes

@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0424_drop_group_forecast_table.py ()

--
-- Raw SQL operation
--

            DROP TABLE "sentry_groupforecast";
            ;

@barkbarkimashark
Copy link
Contributor

You'll need to delete these tests to get tests to pass:
tests/sentry/migrations/test_0417_backfill_groupedmessage_substatus.py
tests/sentry/migrations/test_0420_backfill_groupedmessage_ignored_substatus.py

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That test failure should be unrelated... I'd try just rebasing on latest master

@barkbarkimashark
Copy link
Contributor

That test failure should be unrelated... I'd try just rebasing on latest master

Was referring to this test failure: https://github.com/getsentry/sentry/actions/runs/4747748622/jobs/8433063906

@jangjodi jangjodi merged commit b755fe7 into master Apr 20, 2023
@jangjodi jangjodi deleted the jodi/wor-2966-delete-table branch April 20, 2023 16:32
@armenzg armenzg added this to the Escalating Issues V1 milestone Apr 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants