feat(generic-metrics): Add support for gauges in dataset and processors #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports the subscriptions to opt into using received_p99 for scheduling instead of the current orig_message_ts Needs getsentry/arroyo#295
This reverts commit c7db591. Co-authored-by: lynnagara <1779792+lynnagara@users.noreply.github.com>
ayirr7
changed the title
This reverts commit c7db591. Co-authored-by: lynnagara <1779792+lynnagara@users.noreply.github.com>
…ion (#4915) The main motivations for this are: 1. The amount of delay depends on the synchronization timestamp used, and this is defined at the storage level in code. For example if "orig_message_ts" is used, a longer delay will be applied than if "received_p99" is used, since received will be set earlier in the pipeline. 2. The same CLI args get applied in all Sentry deployments, and this makes it easier to keep them in sync 3. Rolling out different values per storage via CLI will probably break some of our templates and require too much rework. There are no functional changes here since we have 60 configured everywhere right now.
* add test for spans profile_id and fix bug where test was dependent on local timezone
nikhars
approved these changes
Oct 25, 2023
snuba/datasets/metrics_messages.py
Outdated
Comment on lines
94
to
95
| sum = values["sum"] | ||
| count = values["count"] |
There was a problem hiding this comment.
Nit: You can move this directly to lines 101-102
Comment on lines
+43
to
+46
| pytest.param( | ||
| {"type": "d", "metric_id": 2, "value": 20}, | ||
| False, | ||
| id="distribution", |
There was a problem hiding this comment.
Is there a reason you added distribution to the gauge metrics processor test? I would imagine we would never want to do this in production.
There was a problem hiding this comment.
Oh, I think I mainly added it just to check that the gauges processor does not process a message with any other type other than g.
I can remove it if that seems redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Storage + Entity Changes
Processor Changes
Local testing
ingest-performance-metricsKafka topic, all the way to the Gauges aggregate table