fix(minidump): Return process states for minidumps without threads #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
May 23, 2019
jan-auer
added a commit
to getsentry/symbolicator
that referenced
this pull request
May 23, 2019
Fixes two issues in minidump processing: - Includes getsentry/symbolic#146 to process minidumps without thread lists - Backfills the system info architecture from modules if it cannot be extracted from the minidump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #144. Also fixes a memory leak if the minidump cannot be opened.
Please review carefully. This is unfortunately hard to test as I cannot reproduce this case and we stopped to store failing minidumps.