Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support react-native hermes sourcemaps #187

Merged
merged 4 commits into from
Feb 5, 2020
Merged

feat: Support react-native hermes sourcemaps #187

merged 4 commits into from
Feb 5, 2020

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Feb 4, 2020 •
edited
Loading

This treats Hermes SourceMaps slightly differently, resolving the scope name via the bytecode offset.

jan-auer
jan-auer approved these changes Feb 4, 2020
View reviewed changes
sourcemap/src/lib.rs Outdated Show resolved Hide resolved
sourcemap/src/lib.rs Outdated Show resolved Hide resolved
sourcemap/src/lib.rs Outdated Show resolved Hide resolved
jan-auer
jan-auer requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to request changes.

@HazAT
Copy link
Member

HazAT commented Feb 5, 2020

Confirmed, just tested it end to end, it works!

@jan-auer
Copy link
Member

jan-auer commented Feb 5, 2020

Excellent stuff 🎉

When bumping the sourcemap dependency, please also update the cabi/Cargo.lock!

@HazAT HazAT mentioned this pull request Feb 5, 2020
Closed
@Swatinem Swatinem changed the title WIP: feat: support processing of react-native hermes sourcemaps feat: Support processing of react-native hermes sourcemaps Feb 5, 2020
@Swatinem Swatinem marked this pull request as ready for review February 5, 2020 14:31
@Swatinem Swatinem requested a review from a team February 5, 2020 14:31
@jan-auer jan-auer changed the title feat: Support processing of react-native hermes sourcemaps feat: Support react-native hermes sourcemaps Feb 5, 2020
@jan-auer jan-auer merged commit 5c8de65 into master Feb 5, 2020
@jan-auer jan-auer deleted the hermes-sourcemaps branch February 5, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swatinem @HazAT @jan-auer