feat: Expose proguard remapper via c-abi #240
Conversation
cabi/include/symbolic.h
Outdated
| @@ -28,7 +28,7 @@ enum SymbolicErrorCode { | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_UNSUPPORTED_OBJECT = 2101, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_BREAKPAD_OBJECT = 2102, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_ELF_OBJECT = 2103, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_MACH_OOBJECT = 2104, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_MACH_O_OBJECT = 2104, | |||
There was a problem hiding this comment.
not sure if this will cause any problems?
There was a problem hiding this comment.
I manually reverted this. Although its an auto-generated file, so people will run into this again at some point.
There was a problem hiding this comment.
This is indeed strange. It would be a breaking change in the C-ABI, and it will generate a different name for the matching error in the Python layer. I think you can fix this with some sort of configuration for cbindgen, although the new version is actually correct.
cabi/include/symbolic.h
Outdated
| @@ -28,7 +28,7 @@ enum SymbolicErrorCode { | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_UNSUPPORTED_OBJECT = 2101, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_BREAKPAD_OBJECT = 2102, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_ELF_OBJECT = 2103, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_MACH_OOBJECT = 2104, | |||
| SYMBOLIC_ERROR_CODE_OBJECT_ERROR_BAD_MACH_O_OBJECT = 2104, | |||
|
One more ask: What if we mark the old C-ABI functions and Python functions as deprecated? Once we do the next major bump, it's easier to find all the places to remove. |
|
👍 I was able to shim the old functions quite easily, and also copied the |
Exposes the new
proguard::Mapperviacabiandpy.Keeps the old
MappingViewand workspace crate untouched, so this can be released as a minor version, while deprecating and removing the other stuff at some later point.