fix(demangle): Update cpp_demangle due to breaking change #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp_demangle::DemangleOptions now has a no_return_type field which causes an issue in symbolic-demangle lib.rs the breaking change occured in a patch version which means running `cargo update` breaks people's builds.
o0Ignition0o
changed the title
|
Would it be possible to merge & make a new release asap please ? |
|
In case it helps anyone stumbling on it before a new release is out, a workaround in the meantime is to pin cpp_demangle in a Cargo.toml file, for example: symbolic-demangle = "6.1"
cpp_demangle = "=0.2.16" |
|
👍 I'll bump and release. This will take a little bit this time. Next time something like this happens, I think the "right" course of action would be to ask maintainers to yank the offending version and bump properly. |
jan-auer
changed the title
Oh indeed, I'll do just that next time, thanks for your time! |
|
Thanks for reporting this to me btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
cpp_demangle::DemangleOptions now has a no_return_type field which causes an issue in symbolic-demangle lib.rs
the breaking change occured in a patch version which means running
cargo updatebreaks people's builds.